Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to separate out RM-specific code from generic. #589

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Commits on Apr 9, 2024

  1. Configuration menu
    Copy the full SHA
    6a5dbc9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    25a94fd View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    650b13e View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Configuration menu
    Copy the full SHA
    b598096 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Consolidate openehr-rm.

    Remove contents of referencemodels, but retain tests (forn now).
    Package moves to org.openehr to facilitate new RM addition to Archie.
    Some class renames for clarity.
    Revert change to OpenEhrRmInfoLookup.addTypes()
    OpenEhrRmMetaModelsInitialiser.getNativeRms() probably not safe for Android.
    wolandscat committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    4dc3140 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Configuration menu
    Copy the full SHA
    af01876 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Make MetaModels available to lower levels of ADLParser

    Use MetaModels during parsing of CPrimitiveObjects to get access to the correct ModelNamingStrategy. Currently conditional since ADLParser can be created with no MetaModels as well.
    
    In PrimitivesConstraintParser, if the ModelNamingStrategy object can be found, write in the correct RmTypeNames into CPrimitiveObjects (CTerminologyCode and so on).
    
    Rename ArchieModelNamingStrategy to OpenEhrModelNamingStrategy.
    wolandscat committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    038d746 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. Configuration menu
    Copy the full SHA
    8524f12 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a16606 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Move ckm-mirror to the openehr-rm project.

    Move tests with static dependencies on openEHR RM classes from tools to openehr-rm.
    Move or copy other test resources to openehr-rm as needed.
    Create tools/src/testFixtures area for test helper classes shared across projects.
    wolandscat committed May 18, 2024
    Configuration menu
    Copy the full SHA
    f7fae39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca0bea8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8b95bc3 View commit details
    Browse the repository at this point in the history
  4. Move 'parseCKM()' helper function from TestUtil to its own helper cla…

    …ss CkmRepositoryBuilder in openehr-rm.
    
    Use this for any access to the CKM-mirror copy.
    wolandscat committed May 18, 2024
    Configuration menu
    Copy the full SHA
    4795057 View commit details
    Browse the repository at this point in the history
  5. Refactor Diff and flatten parse helper routines to take a 'class' arg…

    …ument so as to use the correct /resources area.
    
    TODO: there might be a better way to do this, but it seems the safest way to share /resources across projects given the Java model of class loading.
    wolandscat committed May 18, 2024
    Configuration menu
    Copy the full SHA
    bdfdd4f View commit details
    Browse the repository at this point in the history
  6. Same refactoring as previous commit for parse helper routines - they …

    …now take a 'class' arg to ensure the corect /resources area is access (i.e. the caller's area, which could be in the same project or another).
    wolandscat committed May 18, 2024
    Configuration menu
    Copy the full SHA
    032630e View commit details
    Browse the repository at this point in the history
  7. Forced by other refactoring to remove static import of CoreMatchers a…

    …nd Assert. Not sure if this matters functionally - probably just an efficiency thing.
    
    TODO: check whether this change introduces any errors, or whether it can be reverted by some other simple change.
    wolandscat committed May 18, 2024
    Configuration menu
    Copy the full SHA
    1f73109 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2a9e0e5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a93f90c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2a3bea9 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Configuration menu
    Copy the full SHA
    9b4d721 View commit details
    Browse the repository at this point in the history