Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in validity directory, and make up to date with current version #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pieterbos
Copy link

Currently implementing validation, phase 1 done except for some warnings and phase 2 about 50%. Found lots of small issues in the adl library, fixed them here.

Main errors:

  1. Old format (1.5 and 1.5.1) files that no longer parse
  2. ENTRY[id1] matches {*} -> ENTRY[id1]
  3. items = < in terminology to new syntax
  4. Some archetypes that tested one error also had other problems that hid the first problem.
  5. Updated ADL version number to 2.0.7 since it's now valid ADL 2.0.7
  6. Some minor syntax errors like extra '>' or '}' characters

Fixes #9
Fixes #3

@wolandscat
Copy link
Member

I've done these corrections and some others manually; also fixed some formatting and email addresses. I didn't want to convert all adl_versions to 2.0.7, because the test set should simulate the real situation that archetypes could have been issued at any 2.x version, not just the latest.

I might still have missed something, so I suggest running another check and see what you find - the remaining errors should be pretty limited I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants