Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update bitstring & test #67

Merged
merged 21 commits into from
Aug 22, 2024
Merged

update bitstring & test #67

merged 21 commits into from
Aug 22, 2024

Conversation

MacOMNI
Copy link
Contributor

@MacOMNI MacOMNI commented Aug 20, 2024

No description provided.

xlc
xlc reviewed Aug 20, 2024
View reviewed changes
Utils/Sources/Utils/Bitstring.swift Outdated Show resolved Hide resolved
Utils/Sources/Utils/Bitstring.swift Outdated Show resolved Hide resolved
Utils/Sources/Utils/Bitstring.swift Outdated Show resolved Hide resolved
Utils/Sources/Utils/Bitstring.swift Outdated Show resolved Hide resolved
@xlc
Copy link
Member

xlc commented Aug 20, 2024

install the precommit hook to lint and format code before commit https://github.com/AcalaNetwork/boka/blob/faf31d8ee24a04d915d6beaa8de095c7c2286b5e/Makefile#L8

xlc
xlc requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only fixed size bitstring is used so we don't need to have variable size bitstring
For fixed size bitstring, the size needs to be configurable. So the implementation should be something like ConfigLimitedSizeArray

.vscode/launch.json Outdated Show resolved Hide resolved
Utils/Sources/Utils/Bitstring.swift Outdated Show resolved Hide resolved
Utils/Sources/Utils/Bitstring.swift Outdated Show resolved Hide resolved
Utils/Tests/UtilsTests/BitStringTests.swift Outdated Show resolved Hide resolved
Utils/Tests/UtilsTests/BitStringTests.swift Outdated Show resolved Hide resolved
Utils/Sources/Utils/ConstValue.swift Outdated Show resolved Hide resolved
Utils/Sources/Utils/Bitstring.swift Outdated Show resolved Hide resolved
xlc
xlc reviewed Aug 21, 2024
View reviewed changes
Utils/Sources/Utils/FixSizeBitstring.swift Outdated Show resolved Hide resolved
Utils/Sources/Utils/FixSizeBitstring.swift Outdated Show resolved Hide resolved
Utils/Sources/Utils/FixSizeBitstring.swift Outdated Show resolved Hide resolved
Utils/Sources/Utils/FixSizeBitstring.swift Outdated Show resolved Hide resolved
Utils/Sources/Utils/FixSizeBitstring.swift Outdated Show resolved Hide resolved
Utils/Sources/Utils/FixSizeBitstring.swift Outdated Show resolved Hide resolved
Utils/Sources/Utils/FixSizeBitstring.swift Outdated Show resolved Hide resolved
MacOMNI and others added 15 commits August 21, 2024 13:40
@MacOMNI @xlc
Update Utils/Sources/Utils/FixSizeBitstring.swift
27061f7 
Co-authored-by: Xiliang Chen <[email protected]>
@MacOMNI @xlc
Update Utils/Sources/Utils/FixSizeBitstring.swift
73b6657 
Co-authored-by: Xiliang Chen <[email protected]>
@MacOMNI @xlc
Update Utils/Sources/Utils/FixSizeBitstring.swift
6f1bb94 
Co-authored-by: Xiliang Chen <[email protected]>
@MacOMNI @xlc
Update Utils/Sources/Utils/FixSizeBitstring.swift
462ecdb 
Co-authored-by: Xiliang Chen <[email protected]>
@MacOMNI @xlc
Update Utils/Sources/Utils/FixSizeBitstring.swift
77c0e1f 
Co-authored-by: Xiliang Chen <[email protected]>
@MacOMNI
update bitstring
93a8ea1
@xlc
Update .vscode/launch.json
520a57f
@MacOMNI
Merge branch 'master' of github.com:AcalaNetwork/boka
b0804b5 
* 'master' of github.com:AcalaNetwork/boka:
  Implements JamCodec and replace with ScaleCodec (#68)
@MacOMNI
Merge branch 'master' into dev_bitstring
7cabca1 
* master:
  Implements JamCodec and replace with ScaleCodec (#68)
@xlc @MacOMNI
Implements JamCodec and replace with ScaleCodec (#68)
c1407ff 
* use Swift Codable

* Codec package

* implement codec

* more refactor

* fmt

* more fix

* disable safrole tests

* comment out safrole tests
@MacOMNI
Merge branch 'dev_bitstring' of github.com:AcalaNetwork/boka into dev…
5ad2b6f 
…_bitstring

* 'dev_bitstring' of github.com:AcalaNetwork/boka:
  Implements JamCodec and replace with ScaleCodec (#68)
@MacOMNI
#update FixSizeBitstring
ddcfc80
@MacOMNI
update config init
58faab5
@MacOMNI
change assurance type to bitstring & test
a5dc413
@xlc
refactor
2299924
@xlc xlc merged commit 317e274 into master Aug 22, 2024
2 checks passed
@xlc xlc deleted the dev_bitstring branch August 22, 2024 22:35
MacOMNI added a commit that referenced this pull request Aug 28, 2024
@MacOMNI
Merge branch 'master' of github.com:AcalaNetwork/boka
f0423dc 
* 'master' of github.com:AcalaNetwork/boka:
  update  bitstring & test (#67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MacOMNI @xlc