move tests from experimental to feature dir (openconfig#3488)

* move tests from experimental to feature dir * removed experimental dir references * removed experimental dir references in contributing.md
open-traffic-generator · Oct 9, 2024 · 2d9dd52 · 2d9dd52
1 parent bd96dd5
commit 2d9dd52
Show file tree

Hide file tree

Showing 149 changed files with 567 additions and 2,107 deletions.
diff --git a/.github/workflows/readme_oc_path_and_rpc.yml b/.github/workflows/readme_oc_path_and_rpc.yml
@@ -37,7 +37,7 @@ jobs:
 
         exemption_flags=(
           --non-test-readme feature/security/gnsi/certz/test_data/README.md
-          --non-test-readme feature/experimental/p4rt/README.md
+          --non-test-readme feature/p4rt/README.md
           --non-test-readme feature/security/gnsi/acctz/README.md
         )
 

diff --git a/.gitignore b/.gitignore
@@ -1,6 +1,7 @@
 *~
 topologies/kne/testbed.kne.yml
 .vscode/
+.idea/
 # used by `make validate_paths`
 openconfig_public/
 # used by `make proto/...`

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -62,10 +62,6 @@ The directory tree is organized as follows:
 *   `cloudbuild/` contains google cloud build scripts for running virtual
     routers in containers on [KNE](https://github.com/openconfig/kne)
 *   `feature/` contains definition and tests of feature profiles.
-*   `feature/experimental` contains tests which have automation which is
-    not confirmed to pass on any hardware platform or software release.
-    When the test automation is passing against at least one DUT,
-    it is moved to the `feature/` directory.
 *   `internal/` contains packages used by feature profile tests.
 *   `proto/` contains protobuf files for feature profiles.
 *   `tools/` contains code used for CI checks.

diff --git a/...bgp_long_lived_graceful_restart/README.md → ...bgp_long_lived_graceful_restart/README.md b/...bgp_long_lived_graceful_restart/README.md → ...bgp_long_lived_graceful_restart/README.md
diff --git a/...t/bgp_long_lived_graceful_restart_test.go → ...t/bgp_long_lived_graceful_restart_test.go b/...t/bgp_long_lived_graceful_restart_test.go → ...t/bgp_long_lived_graceful_restart_test.go
diff --git a/...lived_graceful_restart/metadata.textproto → ...lived_graceful_restart/metadata.textproto b/...lived_graceful_restart/metadata.textproto → ...lived_graceful_restart/metadata.textproto
diff --git a/...sts/base_bgp_session_parameters/README.md → ...sts/base_bgp_session_parameters/README.md b/...sts/base_bgp_session_parameters/README.md → ...sts/base_bgp_session_parameters/README.md
@@ -48,48 +48,21 @@ Test the normal session establishment and termination:
     *   Explicit holdtime interval and keepalive interval.
     *   Explicit connect retry interval.
 
-## Config Parameter coverage
-
-*   For prefix:
-
-    *   /network-instances/network-instance/protocols/protocol/bgp/global
-
-*   For Parameters:
-
-    *   config/as
-    *   config/router-id
-    *   config/peer-as
-    *   config/local-as
-    *   config/description
-    *   timers/config/hold-time
-    *   timers/config/keepalive-interval
-    *   timers/config/minimum-route-advertisement-interval
-
-*   For prefixes:    
-
-    *   /network-instances/network-instance/protocols/protocol/bgp/peer-groups/peer-group
-    *   /network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor
-
-## Telemetry Parameter coverage   
-
-*   For prefix:
-
-    *   /network-instances/network-instance/protocols/protocol/bgp/
-
-*   For Parameters:
-
-    *   state/last-established
-    *   state/messages/received/NOTIFICATION
-    *   state/negotiated-hold-time
-    *   state/supported-capabilities
-
-## Protocol/RPC Parameter coverage
-
-*   BGP
-
-    *   OPEN
-
-        *   Version
-        *   My Autonomous System
-        *   BGP Identifier
-        *   Hold Time
+## OpenConfig Path and RPC Coverage
+```yaml
+paths:
+  ## Config Parameter Coverage
+  /network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/timers/config/hold-time:
+  /network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/timers/config/keepalive-interval:
+
+  ## Telemetry Parameter Coverage
+  /network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/state/last-established:
+  /network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/state/messages/received/NOTIFICATION:
+  /network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/timers/state/negotiated-hold-time:
+  /network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/state/supported-capabilities:
+
+rpcs:
+  gnmi:
+    gNMI.Subscribe:
+    gNMI.Set:
+```
diff --git a/...eters/base_bgp_session_parameters_test.go → ...eters/base_bgp_session_parameters_test.go b/...eters/base_bgp_session_parameters_test.go → ...eters/base_bgp_session_parameters_test.go
diff --git a/...bgp_session_parameters/metadata.textproto → ...bgp_session_parameters/metadata.textproto b/...bgp_session_parameters/metadata.textproto → ...bgp_session_parameters/metadata.textproto
diff --git a/...p/otg_tests/bgp_2byte_4byte_asn/README.md → ...p/otg_tests/bgp_2byte_4byte_asn/README.md b/...p/otg_tests/bgp_2byte_4byte_asn/README.md → ...p/otg_tests/bgp_2byte_4byte_asn/README.md
diff --git a/...yte_4byte_asn/bgp_2byte_4byte_asn_test.go → ...yte_4byte_asn/bgp_2byte_4byte_asn_test.go b/...yte_4byte_asn/bgp_2byte_4byte_asn_test.go → ...yte_4byte_asn/bgp_2byte_4byte_asn_test.go
diff --git a/...ts/bgp_2byte_4byte_asn/metadata.textproto → ...ts/bgp_2byte_4byte_asn/metadata.textproto b/...ts/bgp_2byte_4byte_asn/metadata.textproto → ...ts/bgp_2byte_4byte_asn/metadata.textproto
diff --git a/...bgp_2byte_4byte_asn_policy_test/README.md → ...bgp_2byte_4byte_asn_policy_test/README.md b/...bgp_2byte_4byte_asn_policy_test/README.md → ...bgp_2byte_4byte_asn_policy_test/README.md
diff --git a/...y_test/bgp_2byte_4byte_asn_policy_test.go → ...y_test/bgp_2byte_4byte_asn_policy_test.go b/...y_test/bgp_2byte_4byte_asn_policy_test.go → ...y_test/bgp_2byte_4byte_asn_policy_test.go
diff --git a/..._4byte_asn_policy_test/metadata.textproto → ..._4byte_asn_policy_test/metadata.textproto b/..._4byte_asn_policy_test/metadata.textproto → ..._4byte_asn_policy_test/metadata.textproto
diff --git a/...otg_tests/bgp_afi_safi_defaults/README.md → ...otg_tests/bgp_afi_safi_defaults/README.md b/...otg_tests/bgp_afi_safi_defaults/README.md → ...otg_tests/bgp_afi_safi_defaults/README.md
diff --git a/...fi_defaults/bgp_afi_safi_defaults_test.go → ...fi_defaults/bgp_afi_safi_defaults_test.go b/...fi_defaults/bgp_afi_safi_defaults_test.go → ...fi_defaults/bgp_afi_safi_defaults_test.go
diff --git a/.../bgp_afi_safi_defaults/metadata.textproto → .../bgp_afi_safi_defaults/metadata.textproto b/.../bgp_afi_safi_defaults/metadata.textproto → .../bgp_afi_safi_defaults/metadata.textproto
diff --git a/...tg_tests/bgp_always_compare_med/README.md → ...tg_tests/bgp_always_compare_med/README.md b/...tg_tests/bgp_always_compare_med/README.md → ...tg_tests/bgp_always_compare_med/README.md
@@ -18,20 +18,22 @@ BGP always compare MED
 *   Validate the change of traffic flow because of the change (OTG Port2).
 *   Validate session state and capabilities received on DUT using telemetry.     
 
-## Config Parameter coverage
-
-*   /route-selection-options/config/always-compare-med 
-*   /global/afi-safis/afi-safi/route-selection-options/config/always-compare-med 
-*   /global/route-selection-options/config/always-compare-med 
-
-## Telemetry Parameter coverage
-
-*   /global/afi-safis/afi-safi/route-selection-options/state/always-compare-med 
-*   /global/route-selection-options/state/always-compare-med 
-
-## Protocol/RPC Parameter coverage
-
-N/A
+## OpenConfig Path and RPC Coverage
+```yaml
+paths:
+  ## Config Parameter Coverage
+  /network-instances/network-instance/protocols/protocol/bgp/global/route-selection-options/config/always-compare-med:
+  /network-instances/network-instance/protocols/protocol/bgp/global/afi-safis/afi-safi/route-selection-options/config/always-compare-med:
+
+  ## Telemetry Parameter Coverage
+  /network-instances/network-instance/protocols/protocol/bgp/global/route-selection-options/state/always-compare-med:
+  /network-instances/network-instance/protocols/protocol/bgp/global/afi-safis/afi-safi/route-selection-options/state/always-compare-med:
+
+rpcs:
+  gnmi:
+    gNMI.Subscribe:
+    gNMI.Set:
+```
 
 ## Minimum DUT platform requirement
 

diff --git a/...ompare_med/bgp_always_compare_med_test.go → ...ompare_med/bgp_always_compare_med_test.go b/...ompare_med/bgp_always_compare_med_test.go → ...ompare_med/bgp_always_compare_med_test.go
diff --git a/...bgp_always_compare_med/metadata.textproto → ...bgp_always_compare_med/metadata.textproto b/...bgp_always_compare_med/metadata.textproto → ...bgp_always_compare_med/metadata.textproto
diff --git a/...ride_as_path_split_horizon_test/README.md → ...ride_as_path_split_horizon_test/README.md b/...ride_as_path_split_horizon_test/README.md → ...ride_as_path_split_horizon_test/README.md
diff --git a/...otg_tests/bgp_remove_private_as/README.md → ...otg_tests/bgp_remove_private_as/README.md b/...otg_tests/bgp_remove_private_as/README.md → ...otg_tests/bgp_remove_private_as/README.md
@@ -18,17 +18,20 @@ BGP remove private AS
     *   PRIV_AS1 AS1
     *   AS1 PRIV_AS1 AS2
 
-## Config Parameter coverage
-
-*   /network-instances/network-instance/protocols/protocol/bgp/peer-groups/peer-group/config/remove-private-as
-
-## Telemetry Parameter coverage
-
-*   /network-instances/network-instance/protocols/protocol/bgp/rib/attr-sets/attr-set/as4-path/as4-segment/state
-
-## Protocol/RPC Parameter coverage
-
-N/A
+## OpenConfig Path and RPC Coverage
+```yaml
+paths:
+  ## Config Parameter Coverage
+  /network-instances/network-instance/protocols/protocol/bgp/peer-groups/peer-group/config/remove-private-as:
+
+  ## Telemetry Parameter Coverage
+  /network-instances/network-instance/protocols/protocol/bgp/rib/attr-sets/attr-set/as4-path/as4-segment/state/index:
+
+rpcs:
+  gnmi:
+    gNMI.Subscribe:
+    gNMI.Set:
+```
 
 ## Minimum DUT platform requirement
 

diff --git a/..._private_as/bgp_remove_private_as_test.go → ..._private_as/bgp_remove_private_as_test.go b/..._private_as/bgp_remove_private_as_test.go → ..._private_as/bgp_remove_private_as_test.go
diff --git a/.../bgp_remove_private_as/metadata.textproto → .../bgp_remove_private_as/metadata.textproto b/.../bgp_remove_private_as/metadata.textproto → .../bgp_remove_private_as/metadata.textproto
diff --git a/.../otg_tests/bgp_tcp_mss_path_mtu/README.md → .../otg_tests/bgp_tcp_mss_path_mtu/README.md b/.../otg_tests/bgp_tcp_mss_path_mtu/README.md → .../otg_tests/bgp_tcp_mss_path_mtu/README.md
@@ -25,19 +25,22 @@
 *   Re-establish the IBGP sessions by tcp reset.
 *   Validate that the min MSS value has been adjusted to be below 1500 bytes on the tcp session.
 
-## Config Parameter coverage
-
-*   /neighbors/neighbor/transport/config/tcp-mss 
-*   /neighbors/neighbor/transport/config/mtu-discovery 
-
-## Telemetry Parameter coverage
-
-*   /neighbors/neighbor/transport/state/tcp-mss 
-*   /neighbors/neighbor/transport/state/mtu-discovery 
-
-## Protocol/RPC Parameter coverage
-
-N/A
+## OpenConfig Path and RPC Coverage
+```yaml
+paths:
+  ## Config Parameter Coverage
+  /network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/transport/config/tcp-mss:
+  /network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/transport/config/mtu-discovery:
+
+  ## Telemetry Parameter Coverage
+  /network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/transport/state/tcp-mss:
+  /network-instances/network-instance/protocols/protocol/bgp/neighbors/neighbor/transport/state/mtu-discovery:
+
+rpcs:
+  gnmi:
+    gNMI.Subscribe:
+    gNMI.Set:
+```
 
 ## Minimum DUT platform requirement
 

diff --git a/...mss_path_mtu/bgp_tcp_mss_path_mtu_test.go → ...mss_path_mtu/bgp_tcp_mss_path_mtu_test.go b/...mss_path_mtu/bgp_tcp_mss_path_mtu_test.go → ...mss_path_mtu/bgp_tcp_mss_path_mtu_test.go
diff --git a/...s/bgp_tcp_mss_path_mtu/metadata.textproto → ...s/bgp_tcp_mss_path_mtu/metadata.textproto b/...s/bgp_tcp_mss_path_mtu/metadata.textproto → ...s/bgp_tcp_mss_path_mtu/metadata.textproto
diff --git a/...p/otg_tests/link_bandwidth_test/README.md → ...p/otg_tests/link_bandwidth_test/README.md b/...p/otg_tests/link_bandwidth_test/README.md → ...p/otg_tests/link_bandwidth_test/README.md
diff --git a/...ink_bandwidth_test/link_bandwidth_test.go → ...ink_bandwidth_test/link_bandwidth_test.go b/...ink_bandwidth_test/link_bandwidth_test.go → ...ink_bandwidth_test/link_bandwidth_test.go
diff --git a/...ts/link_bandwidth_test/metadata.textproto → ...ts/link_bandwidth_test/metadata.textproto b/...ts/link_bandwidth_test/metadata.textproto → ...ts/link_bandwidth_test/metadata.textproto
diff --git a/feature/experimental/isis/ate_tests/internal/session/attrs.go b/feature/experimental/isis/ate_tests/internal/session/attrs.go