Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New entry in developer guide to describe the process of adding new fields in the semantic convention registry #209

Merged
merged 3 commits into from
Jun 23, 2024

Conversation

lquerel
Copy link
Contributor

@lquerel lquerel commented Jun 12, 2024

No change in the code.

This PR is to support #202 and any future similar additions to the semconv registry definition.

@lquerel lquerel requested a review from jsuereth as a code owner June 12, 2024 16:29
@lquerel lquerel added the documentation Improvements or additions to documentation label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.4%. Comparing base (3134f3d) to head (701f334).

Current head 701f334 differs from pull request most recent head 561dc5a

Please upload reports for the commit 561dc5a to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #209     +/-   ##
=======================================
- Coverage   74.5%   74.4%   -0.1%     
=======================================
  Files         44      44             
  Lines       2938    2938             
=======================================
- Hits        2189    2187      -2     
- Misses       749     751      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! LGTM

@lquerel lquerel merged commit 183fdeb into open-telemetry:main Jun 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants