-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for loading templates from the file system or from an embedded representation in the app's binary. #171
Merged
lquerel
merged 23 commits into
open-telemetry:main
from
lquerel:embedded-diag-templates
May 28, 2024
Merged
Changes from 14 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
dc096ce
feat(forge): Add FileLoader abstraction to load files from a the file…
lquerel 04e3889
chore(test): Test most of the registry sub-commands.
lquerel ac0e457
chore(test): Test diagnostic init
lquerel 8066f3f
Merge branch 'main' into embedded-diag-templates
lquerel ebe1a90
feat(forge): Add overload mechanism support in EmbeddedFileLoader.
lquerel 1c260a5
chore(test): Improve test coverage
lquerel 2a34b43
chore(test): Improve test coverage
lquerel 7ce0330
chore(test): Improve test coverage
lquerel 03e654c
chore(docker): Add default_diagnostic_templates
lquerel 3dcce6f
chore(docker): Add log in Dockerfile to debug docker build issue
lquerel 4753a09
chore(docker): Add log in Dockerfile to debug docker build issue
lquerel 99e4ff2
chore(docker): Add log in Dockerfile to debug docker build issue
lquerel f32c7e3
chore(docker): Add log in Dockerfile to debug docker build issue
lquerel 3d86ccd
chore(forge): Simplify FileLoader interface based on @jsuereth sugges…
lquerel 3c3f368
chore(update_markdown): Add unit test to the registry update-markdown…
lquerel 0d3dc79
chore(docker): Fix the dockerfile to embedded the default_diagnostic_…
lquerel 84f556d
chore(check-external-types): Fix nightly version for check-external-t…
lquerel 9b8e7a7
feat(forge): Move Send+Sync inside the TemplateEngine instead of in t…
lquerel 37968ce
Merge branch 'main' into embedded-diag-templates
lquerel e241e08
chore(diagnostic): Generate diagnostics from CompoundErrors.
lquerel 7bc1240
chore(diagnostic): Fix diagnostic report in weaver_semconv_gen
lquerel 4b91adc
chore(fmt): Fix cargo fmt issue
lquerel 1277731
chore(just): Fix just file
lquerel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer needed as the default templates are now embedded into the app's binary.