-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't capture db.operation.name
and db.collection.name
from query formats that support multiples
#1566
Open
trask
wants to merge
7
commits into
open-telemetry:main
Choose a base branch
from
trask:refine-operation-and-collection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
refine-operation-and-collection
branch
8 times, most recently
from
November 10, 2024 22:57
c4e26d6
to
4fd09f2
Compare
trask
changed the title
Refine db.operation.name and db.collection.name
Don't capture Nov 10, 2024
db.operation.name
and db.collection.name
from query formats that support multiples
trask
force-pushed
the
refine-operation-and-collection
branch
from
November 10, 2024 23:02
4fd09f2
to
514e388
Compare
trask
force-pushed
the
refine-operation-and-collection
branch
from
November 10, 2024 23:15
d2b3fb2
to
70ed3de
Compare
trask
force-pushed
the
refine-operation-and-collection
branch
from
November 10, 2024 23:15
70ed3de
to
c4db43a
Compare
This was referenced Nov 10, 2024
lmolkova
reviewed
Nov 11, 2024
lmolkova
reviewed
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't capture
db.operation.name
anddb.collection.name
from query formats that support multiples.The reason behind this change is that it could be confusing to have
db.operation.name
anddb.collection.name
captured for some SQL operations but not for other SQL operations, also leading to an inconsistent experience in SQL metrics.And these parsed values (single or multiple) are now present in
db.query.summary
, so the loss of information seems minimal.Specifically,
db.operation.name
is changed from:to:
and
db.collection.name
is changed from:to: