Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "sampling relevant" from metric sections #1551

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Remove "sampling relevant" from metric sections #1551

merged 4 commits into from
Nov 12, 2024

Conversation

trask
Copy link
Member

@trask trask commented Nov 6, 2024 •
edited
Loading

"sampling relevant" is not applicable to metric attributes

lmolkova
lmolkova approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! We should have some better checks/schema preventing metrics attributes from having sampling_relevant property

@lmolkova lmolkova mentioned this pull request Nov 8, 2024
Open
@trask trask added the Skip Changelog Label to skip the changelog check label Nov 8, 2024
@trask trask marked this pull request as ready for review November 8, 2024 19:31
@trask trask requested review from a team as code owners November 8, 2024 19:31
@jsuereth jsuereth merged commit 3c95994 into open-telemetry:main Nov 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees
No one assigned
Labels
Skip Changelog Label to skip the changelog check
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trask @jsuereth @lmolkova