-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RabbitMQ: Specify how to populate messaging.destination.name
#1531
Open
joaopgrassi
wants to merge
11
commits into
open-telemetry:main
Choose a base branch
from
dynatrace-oss-contrib:rabbitmq-destination-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d9574a8
Specify destination name for RabbitMQ
joaopgrassi 6efe0b3
Add changelog
joaopgrassi b02ff2a
Add queue to destination name
joaopgrassi 29209ae
Lint
joaopgrassi 52f57bb
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 9fdf75d
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi f953d89
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 42768c9
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 8567f58
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 70bdbdf
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi 0598254
Merge branch 'main' into rabbitmq-destination-name
joaopgrassi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
change_type: breaking | ||
component: messaging | ||
note: "RabbitMQ: Specify how to populate `messaging.destination.name`" | ||
issues: [1529] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,8 +12,21 @@ The Semantic Conventions for [RabbitMQ](https://www.rabbitmq.com/) extend and ov | |
|
||
## RabbitMQ attributes | ||
|
||
In RabbitMQ, the destination is defined by an *exchange* and a *routing key*. | ||
`messaging.destination.name` MUST be set to the name of the exchange. This will be an empty string if the default exchange is used. | ||
### Destination name | ||
|
||
In RabbitMQ, the destination is defined by an *exchange*, a *routing key* and | ||
for consumers, a *queue*. | ||
`messaging.destination.name` MUST be set to: | ||
|
||
**Producers** | ||
|
||
- `{exchange}:{routing key}` when both values are present and non-empty. | ||
If any has an empty value (e.g., the default exchange is used) it SHOULD be omitted. | ||
- Otherwise: `amq.default` | ||
|
||
**Consumers** | ||
- `{exchange}:{routing key}:{queue}` when all values are present and non-empty. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe check if routing key and queue are the same and populate just one |
||
If any has an empty value (e.g., the default exchange is used) it SHOULD be omitted. | ||
|
||
<!-- semconv messaging.rabbitmq --> | ||
<!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. --> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's consider
.
to match what we do in DBs