feedback

open-telemetry · Oct 27, 2024 · 9313ca9 · 9313ca9
1 parent 677eef5
commit 9313ca9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/policies/yaml_schema.rego b/policies/yaml_schema.rego
@@ -110,7 +110,7 @@ deny[yaml_schema_violation(description, group.id, name)] {
     group.type == "resource"
     name := group.name
 
-    # TODO: remove once TODO is fixed
+    # TODO: remove once https://github.com/open-telemetry/semantic-conventions/pull/1423 is merged
     exclusions := {"telemetry.sdk_experimental", "service_experimental"}
     exclusions[name] != null
 

diff --git a/policies/yaml_schema_test.rego b/policies/yaml_schema_test.rego
@@ -89,6 +89,17 @@ test_fails_on_invalid_span_id if {
     }
 }
 
+test_fails_on_invalid_resource_id if {
+    invalid_ids := [
+        "foo.bar",
+        "resource..foo.bar",
+        "resource.foo.bar.deprecated",
+    ]
+    every id in invalid_ids {
+        count(deny) >= 1 with input as {"groups": [{"id": id, "type": "resource", "name": "foo.bar"}]}
+    }
+}
+
 create_attribute_group(attr) = json {
     json := [{"id": "yaml_schema.test", "attributes": [{"id": attr}]}]
 }