Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user_events metrics exporter to otel 0.27, add internal logs #129

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Nov 15, 2024

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner November 15, 2024 06:44
@lalitb lalitb changed the title Update user_events metrics exporter to 0.27, add internal logs Update user_events metrics exporter to otel 0.27, add internal logs Nov 15, 2024
error = err.to_string(),
metric_name = metric_name,
metric_type = metric_type,
size = byte_array.len());
Copy link
Member Author

@lalitb lalitb Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logged as debug here with extra details, it will be logged as error in PeriodicReader.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 117 lines in your changes missing coverage. Please review.

Project coverage is 55.4%. Comparing base (d407cbf) to head (53330ca).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ntelemetry-user-events-metrics/src/exporter/mod.rs 0.0% 107 Missing ⚠️
...elemetry-user-events-metrics/src/tracepoint/mod.rs 0.0% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #129     +/-   ##
=======================================
- Coverage   56.0%   55.4%   -0.7%     
=======================================
  Files         39      39             
  Lines       6037    6105     +68     
=======================================
  Hits        3385    3385             
- Misses      2652    2720     +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog update too.

@lalitb lalitb merged commit 559fe64 into open-telemetry:main Nov 15, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants