Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ruff rule A #4232

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding ruff rule A #4232

wants to merge 3 commits into from

Conversation

Neema-Joju
Copy link

@Neema-Joju Neema-Joju commented Oct 22, 2024 •
edited by emdneto
Loading

Description

Address part of #4227

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • ruff check . (This test lints all discovered Python files. Adding rule A affects variable, argument, import, module names.)

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@Neema-Joju Neema-Joju requested a review from a team as a code owner October 22, 2024 01:55
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 22, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

xrmx
xrmx reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can just skip the A instead?

docs/conf.py Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
opentelemetry-api/src/opentelemetry/baggage/__init__.py Outdated Show resolved Hide resolved
shim/opentelemetry-opentracing-shim/src/opentelemetry/shim/opentracing_shim/__init__.py Outdated Show resolved Hide resolved
@emdneto emdneto mentioned this pull request Oct 22, 2024
Open
4 tasks
@Neema-Joju
Copy link
Author

Maybe I'll just revert back all changes and just stick to adding rules. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdneto emdneto emdneto left review comments

@xrmx xrmx xrmx left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neema-Joju @xrmx @emdneto