opentelemetry-instrumentation-openai-v2: add codefromthecrypt and fix yaml fixture #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… yaml fixture Follow-up to open-telemetry#2945 See open-telemetry#2984 (comment) Signed-off-by: Adrian Cole <[email protected]>
8 tasks
github-actions
bot
assigned codefromthecrypt, gyliu513, karthikscale3, lmolkova, lzchen and nirga
github-actions
bot
requested review from
gyliu513,
karthikscale3,
lmolkova,
lzchen and
nirga
xrmx
approved these changes
Nov 11, 2024
alizenhom
approved these changes
Nov 11, 2024
lzchen
approved these changes
Nov 11, 2024
alizenhom
pushed a commit
to alizenhom/opentelemetry-python-contrib
that referenced
this pull request
Nov 11, 2024
alizenhom
pushed a commit
to alizenhom/opentelemetry-python-contrib
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before, the pretty-print formatter for openai test yaml wasn't consistently loaded (from #2945).
This also, adds myself into the contributors so I automatically get notified on PRs (as I missed the problem in #2984)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I deleted one test yaml and ran the test two ways to make sure it recreates correctly
tox -e py312-test-instrumentation-openai-v2-0tox -e py312-test-instrumentation-openai-v2-1Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.