Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generate-workflows usage to CONTRIBUTING #2977

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Add generate-workflows usage to CONTRIBUTING #2977

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48e66f0
Add generate-workflows usage
tammy-baylis-swi Nov 7, 2024
b3e6e84
Update Bumping the Python baseline
tammy-baylis-swi Nov 8, 2024
1fb65a0
Merge branch 'main' into add-generate-workflows-info
tammy-baylis-swi Nov 8, 2024
9a15a1f
Merge branch 'main' into add-generate-workflows-info
lzchen Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ You can run `tox` with the following arguments:
Python version
* `tox -e spellcheck` to run a spellcheck on all the code
* `tox -e lint-some-package` to run lint checks on `some-package`
* `tox -e generate-workflows` to run creation of new CI workflows if tox environments have been updated
* `tox -e ruff` to run ruff linter and formatter checks against the entire codebase

`ruff check` and `ruff format` are executed when `tox -e ruff` is run. We strongly recommend you to configure [pre-commit](https://pre-commit.com/) locally to run `ruff` automatically before each commit by installing it as git hooks. You just need to [install pre-commit](https://pre-commit.com/#install) in your environment:
Expand Down Expand Up @@ -306,6 +307,6 @@ When adding support for a new Python release remember to:

- Add the version in `tox.ini`
- Add the version in `pyproject.toml` trove classifiers
- Update github workflows accordingly; lint and benchmarks use the latest supported version
- Update github workflows accordingly with `tox -e generate-workflows`; lint and benchmarks use the latest supported version
tammy-baylis-swi marked this conversation as resolved.
Show resolved Hide resolved
- Update `.pre-commit-config.yaml`
- Update tox examples in the documentation