Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to work with SQLAlchemy 2 #2976

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Update tests to work with SQLAlchemy 2 #2976

merged 4 commits into from
Nov 7, 2024

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Nov 7, 2024 •
edited
Loading

Description

Fixes #2975

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Run unit tests via tox -e py312-test-instrumentation-sqlalchemy-1 as current, then with temporary update to test-requirements-1.txt with SQLAlchemy==2.0.35

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@github-actions github-actions bot requested a review from shalevr November 7, 2024 21:28
@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review November 7, 2024 21:29
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner November 7, 2024 21:29
@tammy-baylis-swi tammy-baylis-swi mentioned this pull request Nov 7, 2024
Merged
emdneto
emdneto reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emdneto
add tests to CI
ada27a5 
Signed-off-by: emdneto <[email protected]>
lzchen
lzchen reviewed Nov 7, 2024
View reviewed changes
tox.ini Show resolved Hide resolved
lzchen
lzchen approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit.

@lzchen lzchen merged commit 1d8286c into open-telemetry:main Nov 7, 2024
566 checks passed
lzchen pushed a commit that referenced this pull request Nov 7, 2024
@tammy-baylis-swi @lzchen
Update tests to work with SQLAlchemy 2 (#2976)
402155e
@tammy-baylis-swi tammy-baylis-swi mentioned this pull request Nov 8, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@emdneto emdneto emdneto approved these changes

@shalevr shalevr Awaiting requested review from shalevr

Assignees

@shalevr shalevr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update SQLAlchemy instrumentor tests to work with SQLAlchemy 2
4 participants
@tammy-baylis-swi @emdneto @lzchen @shalevr