Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLAlchemy instrumentor populates span after sqlcomment creation, not before #2937

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

SQLAlchemy instrumentor populates span after sqlcomment creation, not before #2937

wants to merge 10 commits into from

Commits on Oct 29, 2024

  1. Set db.statement after create sqlcomment

    @tammy-baylis-swi
    tammy-baylis-swi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1d2e7c9 View commit details
    Browse the repository at this point in the history

  2. Add test

    @tammy-baylis-swi
    tammy-baylis-swi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ad8948a View commit details
    Browse the repository at this point in the history

  3. Changelog

    @tammy-baylis-swi
    tammy-baylis-swi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b1fbeb7 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Merge branch 'main' into sqlalchemy-db-statement-with-sqlcomment

    @tammy-baylis-swi
    tammy-baylis-swi authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    94aca0e View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge branch 'main' into sqlalchemy-db-statement-with-sqlcomment

    @tammy-baylis-swi
    tammy-baylis-swi authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c5a7534 View commit details
    Browse the repository at this point in the history

  2. _add_sql_comment only if span.is_recording

    @tammy-baylis-swi
    tammy-baylis-swi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e3ddea9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into sqlalchemy-db-statement-with-sqlcomment

    @tammy-baylis-swi
    tammy-baylis-swi authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    1a11e3b View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Merge branch 'main' into sqlalchemy-db-statement-with-sqlcomment

    @tammy-baylis-swi
    tammy-baylis-swi authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    85b1cd4 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Merge branch 'main' into sqlalchemy-db-statement-with-sqlcomment

    @tammy-baylis-swi
    tammy-baylis-swi authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2c68a97 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Fix test for sqlalchemy 2

    @tammy-baylis-swi
    tammy-baylis-swi committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7b78383 View commit details
    Browse the repository at this point in the history