fix: fastapi auto-instrumentation by removing fastapi-slim support
#2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
smoke
force-pushed
the
fix/fastapi-auto-instrumentation-remove-fastapi-slim-support
branch
2 times, most recently
from
162363f
to
6389d14
Compare
Moreover `fastapi-slim` itself is discontinued from maintainers see fastapi/fastapi#11522 (comment) see https://fastapi.tiangolo.com/release-notes/#01120
smoke
force-pushed
the
fix/fastapi-auto-instrumentation-remove-fastapi-slim-support
branch
from
6389d14
to
6e7f204
Compare
|
Checks fail because of side flacky test |
emdneto
reviewed
Aug 7, 2024
emdneto
reviewed
Aug 7, 2024
Co-authored-by: Emídio Neto <[email protected]>
Co-authored-by: Emídio Neto <[email protected]>
tammy-baylis-swi
approved these changes
Aug 7, 2024
emdneto
approved these changes
Aug 8, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fastapi-slimsupport was introduced via #2683 as a response tofastapimaintainers adding a no-dependencies package calledfastapi-slim.The changes over
opentelemetry-instrumentation-fastapihave broken auto-instrumentation viaopentelemetry-instrumentas reproduced here https://github.com/smoke/fastapi-autoinstrumentation-failscausing
Skipping instrumentation fastapi: DependencyConflict: requested: "fastapi-slim~=0.111.0" but found: "None"(when used with OTEL_PYTHON_LOG_LEVEL=debug as #1745 is not yet available)The
fastapi-slimitself is discontinued from maintainers as it caused issues with users of it.Given it causes issues with opentelemetry auto-instrumentation as well, it is removed as most feasible option.
see fastapi/fastapi#11522 (comment)
see https://fastapi.tiangolo.com/release-notes/#01120
Fixes #2683 (comment)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.