Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NoOpTraceProvider test for opentelemetry-instrumentation-logging #2649

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

the-chandru
Copy link
Contributor

@the-chandru the-chandru commented Jul 1, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #976

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e test-instrumentation-logging

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Unit tests have been added

@the-chandru
Copy link
Contributor Author

Need to check about CCLA

@the-chandru the-chandru reopened this Jul 11, 2024
Copy link

linux-foundation-easycla bot commented Jul 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@xrmx xrmx changed the title Added testcode For #976 Add NoOpTraceProvider test for opentelemetry-instrumentation-logging Jul 17, 2024
@xrmx
Copy link
Contributor

xrmx commented Jul 17, 2024

Please fix linting, you can configure pre-commit as written in CONTRIBUTING.md

@the-chandru
Copy link
Contributor Author

Please fix linting, you can configure pre-commit as written in CONTRIBUTING.md

Working on it!

@the-chandru
Copy link
Contributor Author

@xrmx - The review comment has been addressed and the changes are pushed into PR. Thanks.

@lzchen lzchen added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 22, 2024
@lzchen
Copy link
Contributor

lzchen commented Jul 22, 2024

@the-chandru

Please rebase with main so we can merge. Also if you can set pr settings to allow edits from maintainers, you can allow us to do this for you.

@the-chandru
Copy link
Contributor Author

@the-chandru

Please rebase with main so we can merge. Also if you can set pr settings to allow edits from maintainers, you can allow us to do this for you.

Hello @lzchen thanks for the approval, I am not sure if I have an option to allow edits from maintainers as my changes are through organization fork/repos.

For the rebase, did you mean the option shown in the screenshot below?
image

@xrmx
Copy link
Contributor

xrmx commented Jul 23, 2024

@the-chandru they are both fine

@the-chandru
Copy link
Contributor Author

@the-chandru they are both fine

Thanks @xrmx I just did the rebase.

@lzchen lzchen merged commit 948b47d into open-telemetry:main Jul 23, 2024
377 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit and test opentelemetry-instrumentation-logging
4 participants