-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NoOpTraceProvider test for opentelemetry-instrumentation-logging #2649
Add NoOpTraceProvider test for opentelemetry-instrumentation-logging #2649
Conversation
Need to check about CCLA |
Please fix linting, you can configure pre-commit as written in CONTRIBUTING.md |
Working on it! |
@xrmx - The review comment has been addressed and the changes are pushed into PR. Thanks. |
Please rebase with main so we can merge. Also if you can set pr settings to allow edits from maintainers, you can allow us to do this for you. |
Hello @lzchen thanks for the approval, I am not sure if I have an option to allow edits from maintainers as my changes are through organization fork/repos. For the rebase, did you mean the option shown in the screenshot below? |
@the-chandru they are both fine |
Signed-off-by: C, Chandru <[email protected]>
Signed-off-by: C, Chandru <[email protected]>
3b90f24
to
311d679
Compare
Thanks @xrmx I just did the rebase. |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #976
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.