Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flask: add http.target and http.route to metric attributes #2621

Merged
merged 27 commits into from
Jul 22, 2024
Merged

flask: add http.target and http.route to metric attributes #2621

merged 27 commits into from
Jul 22, 2024

Conversation

GonzaloGuasch
Copy link
Contributor

Description

Taking up this closed PR, when sending metrics in the Flask instrumentation, the http.route attribute is added to them.
This attribute is super important in the use of metrics and will greatly improve the experience of using Flask. This change was tested locally.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

running: tox -e test-instrumentation-flask

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@GonzaloGuasch GonzaloGuasch requested a review from a team June 19, 2024 14:50
@github-actions github-actions bot requested a review from ocelotl June 19, 2024 15:00
@GonzaloGuasch GonzaloGuasch mentioned this pull request Jun 19, 2024
Closed
10 tasks
This was referenced Jun 19, 2024
Closed
Merged
@xrmx xrmx changed the title add metric attribute flask: add http.route to metric attributes Jun 20, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 24, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

xrmx
xrmx reviewed Jul 1, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@GonzaloGuasch GonzaloGuasch requested a review from xrmx July 1, 2024 14:57
@GonzaloGuasch GonzaloGuasch changed the title flask: add http.route to metric attributes flask: add http.route to metric attributes Jul 1, 2024
@GonzaloGuasch
Copy link
Contributor Author

GonzaloGuasch commented Jul 8, 2024 •
edited
Loading

@xrmx @ocelotl do you think this PR is ready to merge?

emdneto
emdneto reviewed Jul 8, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@xrmx xrmx changed the title flask: add http.route to metric attributes flask: add http.target and http.route to metric attributes Jul 18, 2024
@lzchen lzchen merged commit a322a0a into open-telemetry:main Jul 22, 2024
377 checks passed
emdneto pushed a commit to emdneto/opentelemetry-python-contrib that referenced this pull request Jul 22, 2024
@GonzaloGuasch @emdneto
flask: add http.target and http.route to metric attributes (open-…
b604d64 
…telemetry#2621)
@lzchen lzchen mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@emdneto emdneto emdneto approved these changes

@alexmojaki alexmojaki alexmojaki approved these changes

@xrmx xrmx xrmx approved these changes

@ocelotl ocelotl Awaiting requested review from ocelotl

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GonzaloGuasch @xrmx @alexmojaki @emdneto @lzchen @ocelotl