fix tests for falcon 1 & 2

open-telemetry · Aug 9, 2024 · 228897d · 228897d
1 parent 2d68dc5
commit 228897d
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/instrumentation/opentelemetry-instrumentation-falcon/tests/test_falcon.py b/instrumentation/opentelemetry-instrumentation-falcon/tests/test_falcon.py
@@ -186,7 +186,16 @@ def test_500(self):
         self.assertEqual(span.name, "GET /error")
         self.assertFalse(span.status.is_ok)
         self.assertEqual(span.status.status_code, StatusCode.ERROR)
-        self.assertEqual(span.status.description, None)
+
+        _parsed_falcon_version = package_version.parse(_falcon_version)
+        if _parsed_falcon_version < package_version.parse("3.0.0"):
+            self.assertEqual(
+                span.status.description,
+                "NameError: name 'non_existent_var' is not defined",
+            )
+        else:
+            self.assertEqual(span.status.description, None)
+
         self.assertSpanHasAttributes(
             span,
             {