Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support google protobuf v4 #1421

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Support google protobuf v4 #1421

merged 1 commit into from
Oct 30, 2024

Conversation

roxblnfk
Copy link
Contributor

If google protobuf v4 is not allowed, the package version 1.0.0beta5 will be installed, which breaks the application.

The same value is in the root composer.json:

"google/protobuf": "^3.22 || ^4.0",

@roxblnfk roxblnfk requested a review from a team as a code owner October 30, 2024 07:48
Copy link

welcome bot commented Oct 30, 2024

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

Copy link

linux-foundation-easycla bot commented Oct 30, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for opentelemetry-php canceled.

Name Link
🔨 Latest commit 108cedf
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-php/deploys/6721e4ce7830030008153516

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (1aae9dd) to head (108cedf).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1421      +/-   ##
============================================
+ Coverage     73.56%   73.69%   +0.12%     
  Complexity     2683     2683              
============================================
  Files           387      387              
  Lines          7975     7975              
============================================
+ Hits           5867     5877      +10     
+ Misses         2108     2098      -10     
Flag Coverage Δ
8.1 73.29% <ø> (-0.03%) ⬇️
8.2 73.48% <ø> (-0.01%) ⬇️
8.3 73.63% <ø> (+0.13%) ⬆️
8.4 73.48% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aae9dd...108cedf. Read the comment docs.

@brettmc brettmc merged commit 39cc549 into open-telemetry:main Oct 30, 2024
14 checks passed
@brettmc
Copy link
Collaborator

brettmc commented Oct 30, 2024

tagged 1.2.1 with this change, @roxblnfk

@roxblnfk roxblnfk deleted the patch-1 branch October 30, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants