Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static import for semconv attributes in camel tests #12780

Merged

Conversation

jaydeluca
Copy link
Member

Related to #12575, #12580, #12578

@jaydeluca jaydeluca requested a review from a team as a code owner November 23, 2024 13:34
@jaydeluca jaydeluca changed the title use static import for semconv attributes in tests Use static import for semconv attributes in camel tests Nov 23, 2024
@@ -66,6 +66,7 @@ rough guideline of what are commonly accepted static imports:
- Immutable constants (where clearly named)
- Singleton instances (especially where clearly named and hopefully immutable)
- `tracer()` methods that expose tracer singleton instances
- Semantic convention attribute keys used in tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 520fc73 into open-telemetry:main Nov 23, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants