Fill jvm.thread.state attribute for jvm.thread.count metric on jdk8 #12724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Nov 13, 2024
|
|
||
| // Visible for testing | ||
| static Thread[] getThreads() { | ||
| ThreadGroup threadGroup = Thread.currentThread().getThreadGroup(); |
There was a problem hiding this comment.
initially I planned to use reflection to call Thread.getThreads(), but that method is not available on openj9
laurit
commented
Nov 13, 2024
| } | ||
|
|
||
| // Visible for testing | ||
| List<AutoCloseable> registerObservers(OpenTelemetry openTelemetry, ThreadMXBean threadBean) { | ||
| return registerObservers( | ||
| openTelemetry, | ||
| isJava9OrNewer() ? Threads::java9AndNewerCallback : Threads::java8Callback, |
There was a problem hiding this comment.
the java8Callback is only used in tests
jaydeluca
approved these changes
Nov 15, 2024
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
akats7
pushed a commit
to akats7/opentelemetry-java-instrumentation
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12614 and #11980
Currently on jdk8 we don't fill
jvm.thread.stateattribute because through the jmx apis on jdk 8 we can't getjvm.thread.stateandjvm.thread.daemonat the same time. This PR provides an alternative implementation based onjava.lang.Threadthat can fill both of these attributes on jdk8.