[chore]: enable int-conversion rule of perfsprint #5964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
requested review from
MrAlias,
XSAM,
dashpole,
pellared and
dmathieu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5964 +/- ##
=====================================
Coverage 84.6% 84.6%
=====================================
Files 272 272
Lines 22897 22897
=====================================
Hits 19391 19391
Misses 3162 3162
Partials 344 344 |
mmorel-35
force-pushed
the
golangci-lint/perfsprint
branch
2 times, most recently
from
94207b1
to
0d48e02
Compare
MrAlias
reviewed
Nov 10, 2024
pellared
approved these changes
Nov 12, 2024
dmathieu
approved these changes
Nov 12, 2024
mmorel-35
force-pushed
the
golangci-lint/perfsprint
branch
from
0d48e02
to
2568616
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
golangci-lint/perfsprint
branch
from
2568616
to
6f2881a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
perfsprint is a linter for performance, aiming at usages of fmt.Sprintf which have faster alternatives.
This PR enables int-conversion rule