-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement resource serialization for stdoutlog #5213
Merged
pellared
merged 12 commits into
open-telemetry:main
from
XSAM:fix-resource-serialization
Apr 22, 2024
Merged
Implement resource serialization for stdoutlog #5213
pellared
merged 12 commits into
open-telemetry:main
from
XSAM:fix-resource-serialization
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSAM
requested review from
MrAlias,
Aneurysm9,
evantorrie,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
April 15, 2024 23:11
pellared
reviewed
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5213 +/- ##
=======================================
- Coverage 85.5% 85.5% -0.1%
=======================================
Files 258 258
Lines 17030 17031 +1
=======================================
Hits 14570 14570
- Misses 2152 2153 +1
Partials 308 308
|
MrAlias
reviewed
Apr 16, 2024
pellared
approved these changes
Apr 17, 2024
MrAlias
approved these changes
Apr 18, 2024
@open-telemetry/go-approvers This needs a review from a non-Splunker. |
dmathieu
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5211
Adding tests for this behavior is not easy until a test record structure like #5200 is implemented. I will include the test on #5212.