Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update semconv to spec release 1.20.0 #579

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tsloughter
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4bef26e) 38.11% compared to head (882af82) 38.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #579   +/-   ##
=======================================
  Coverage   38.11%   38.11%           
=======================================
  Files          61       61           
  Lines        3597     3597           
=======================================
  Hits         1371     1371           
  Misses       2226     2226           
Flag Coverage Δ
api 67.91% <ø> (ø)
elixir 18.29% <ø> (ø)
erlang 38.09% <ø> (ø)
exporter 8.11% <ø> (ø)
sdk 78.13% <ø> (ø)
zipkin 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ferd ferd self-requested a review April 29, 2023 17:39
@ferd
Copy link
Member

ferd commented Apr 29, 2023

Woops, changes seemed straightforward (autogenerated code) but tests appear to fail here and there.

@tsloughter
Copy link
Member Author

Ah, yup, Elixir module ends up with the wrong name with this change.

@andrewhr
Copy link
Contributor

andrewhr commented Aug 18, 2023

I'm not familiar with the codegen tool, but would be great if we could maintain old attributes as deprecated and maybe aliases, example:

@deprecated "use new_name/0 instead"
def old_name(), do: new_name()

That works even for removed attributes, which deprecated message will say it's removed.

My concern is to make it backward compatible as possible, otherwise this library will end up locking dozens of other libraries, given our approach for Erlang/Elixir to be micro-libraries for each instrumentation.

Would be that possible?

@@ -2,8 +2,8 @@

set -ex

semconv_version='1.13.0'
docker_img_vsn='0.14.0'
semconv_version='1.20.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime, we got 1.21.0 released 😬

@bryannaegele
Copy link
Contributor

We could probably keep a list of them, mark them there and in the changelog, and then set a policy for removal. This doesn't get updated often so it doesn't seem like a big burden to add/modify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants