Deprecate funcs that repeate receiver in name #11287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
deprecate-receiver-name
branch
3 times, most recently
from
2d216d1
to
e634db1
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
deprecate-receiver-name
branch
from
e634db1
to
cf06b16
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11287 +/- ##
==========================================
- Coverage 91.52% 91.45% -0.08%
==========================================
Files 424 424
Lines 20222 20238 +16
==========================================
Hits 18509 18509
- Misses 1329 1345 +16
Partials 384 384 ☔ View full report in Codecov by Sentry. |
songy23
approved these changes
Sep 27, 2024
djaglowski
approved these changes
Sep 27, 2024
That would mean I have to change connectors as well :(((... Happy to do it if others feel the same. |
|
So I would lean towards keeping |
dmitryax
approved these changes
Sep 27, 2024
bogdandrutu
added a commit
that referenced
this pull request
Sep 30, 2024
Similar with #11287 Signed-off-by: Bogdan Drutu <[email protected]>
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
This change makes the names to be more "Go" friendly. Also it will not become an issue that types will try to implement different Factory types (receiver,processor) because that is forbidden because of our design. This also makes the names consistent with connector.Factory. Signed-off-by: Bogdan Drutu <[email protected]>
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
Similar with open-telemetry#11287 Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the names to be more "Go" friendly. Also it will not become an issue that types will try to implement different Factory types (receiver,processor) because that is forbidden because of our design. This also makes the names consistent with connector.Factory.