Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component] Remove deprecated DataType #11253

Merged

Conversation

TylerHelmuth
Copy link
Member

Description

Continues the switch to use pipeline.ID and pipeline.Signal.

  • Removes deprecated code
  • Continues rename process for function/type changes.

Link to tracking issue

Related to #9429

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (e69f2f3) to head (223bdb3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11253      +/-   ##
==========================================
- Coverage   91.56%   91.53%   -0.04%     
==========================================
  Files         424      430       +6     
  Lines       20242    20240       -2     
==========================================
- Hits        18535    18526       -9     
- Misses       1331     1340       +9     
+ Partials      376      374       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth TylerHelmuth marked this pull request as ready for review September 24, 2024 14:35
@TylerHelmuth TylerHelmuth requested a review from a team as a code owner September 24, 2024 14:35
@TylerHelmuth TylerHelmuth added the release:blocker The issue must be resolved before cutting the next release label Sep 26, 2024
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please make this 6 PRs one per changelog entry? That would be really appreciated for reviewers.

@bogdandrutu
Copy link
Member

Anything left here?

@TylerHelmuth
Copy link
Member Author

@bogdandrutu 2 more here:

Once these are merged I'll update this PR to be the removal of component.DataType.

@TylerHelmuth
Copy link
Member Author

@bogdandrutu this PR is now scoped to only the component deprecations.

@TylerHelmuth TylerHelmuth changed the title [component] Continue deprecation process of component.DataType [component] Remove deprecated component.DataType Oct 1, 2024
@TylerHelmuth TylerHelmuth changed the title [component] Remove deprecated component.DataType [component] Remove deprecated DataType Oct 1, 2024
@bogdandrutu
Copy link
Member

@TylerHelmuth thank you, hope you see the power of small focus PRs :)

@bogdandrutu bogdandrutu merged commit dfa6b6e into open-telemetry:main Oct 1, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 1, 2024
@TylerHelmuth TylerHelmuth deleted the pipeline-continue-refactor branch October 1, 2024 20:55
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this pull request Oct 8, 2024
#### Description

Continues the switch to use `pipeline.ID` and `pipeline.Signal`.
- Removes deprecated code
- Continues rename process for function/type changes.

#### Link to tracking issue
Related to
open-telemetry#9429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants