Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add exporterhelperprofiles package #11226

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Sep 20, 2024

Description

This is extracted from #11131.
It adds profiles support for the epxorterhelper, so both the otlp and otlphttp exporters can support that signal.

It requires #11207 and #11225(done) to be merged first.

@dmathieu dmathieu force-pushed the exporterhelperprofiles branch 3 times, most recently from 2c2f0ce to daed833 Compare September 20, 2024 08:43
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 92.13483% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.80%. Comparing base (18e4b49) to head (b740c57).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../exporterhelper/exporterhelperprofiles/profiles.go 91.80% 3 Missing and 2 partials ⚠️
exporter/exporterhelper/internal/obsexporter.go 0.00% 5 Missing ⚠️
...terhelper/exporterhelperprofiles/profiles_batch.go 97.75% 1 Missing and 1 partial ⚠️
exporter/exporterhelper/internal/request.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11226      +/-   ##
==========================================
- Coverage   91.80%   91.80%   -0.01%     
==========================================
  Files         424      428       +4     
  Lines       20094    20259     +165     
==========================================
+ Hits        18447    18598     +151     
- Misses       1268     1279      +11     
- Partials      379      382       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants