Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC [exporter] queue->batching pulling model to queue->batching pushing model - single thread version #11200

Conversation

sfc-gh-sili
Copy link
Contributor

Description

Link to tracking issue

Fixes #

Testing

Documentation

@sfc-gh-sili sfc-gh-sili force-pushed the sili-queue-batcher-single-thread-reading branch from f2287b9 to 11a88e9 Compare September 18, 2024 00:21
@sfc-gh-sili sfc-gh-sili force-pushed the sili-queue-batcher-single-thread-reading branch 9 times, most recently from e9c489b to c451052 Compare October 3, 2024 01:58
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 92.44186% with 13 lines in your changes missing coverage. Please review.

Project coverage is 91.31%. Comparing base (4ace638) to head (9645977).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
exporter/internal/queue/batcher.go 94.44% 4 Missing and 3 partials ⚠️
exporter/internal/queue/persistent_queue.go 76.19% 4 Missing and 1 partial ⚠️
exporter/internal/queue/bounded_memory_queue.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11200      +/-   ##
==========================================
- Coverage   91.51%   91.31%   -0.20%     
==========================================
  Files         430      429       -1     
  Lines       20226    20389     +163     
==========================================
+ Hits        18509    18619     +110     
- Misses       1342     1385      +43     
- Partials      375      385      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-sili sfc-gh-sili force-pushed the sili-queue-batcher-single-thread-reading branch 5 times, most recently from 06e7b9a to 8ec4769 Compare October 7, 2024 19:49
@sfc-gh-sili sfc-gh-sili force-pushed the sili-queue-batcher-single-thread-reading branch from 8ec4769 to 72a1e7a Compare October 7, 2024 19:51
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 22, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant