add default readtimeout and writetimeout #10701
Conversation
@codeboten hi , how can i Restart this process. |
J-lena
force-pushed
the
main
branch
3 times, most recently
from
4f0a5f7
to
e21f127
Compare
Signed-off-by: lenajiang <[email protected]>
|
@J-lena it looks like the easy CLA check is all good now
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@codeboten hi,has any problems about this commit? |
| @@ -48,6 +48,7 @@ $(TOOLS_BIN_NAMES): $(TOOLS_BIN_DIR) $(TOOLS_MOD_DIR)/go.mod | |||
|
|
|||
| .PHONY: test | |||
| test: | |||
| # $(GOTEST) $(GOTEST_OPT) -run TestSetDefaultConfig | |||
| } | ||
|
|
||
| if cfg.HTTP.WriteTimeout == 0 { | ||
| cfg.HTTP.WriteTimeout = defaultTimeout |
There was a problem hiding this comment.
at the very least this should be spelled out on the README.
This is not the right place to add this default value - it should be done in createDefaultConfig instead:
We can also change the way the default config is computed to use the confighttp.NewServerConfig and configgrpc.NewServerConfig instead of initializing structs by itself.
|
Please add a changelog. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description
Link to tracking issue
Fixes #10469
Testing
add a test function : TestSetDefaultConfig. beasecause the config_test has some failures, so i change makefile.common to only run mytest
Documentation