fix: support indexing more types #36401
Open
+171
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znd4
requested review from
TylerHelmuth,
bogdandrutu,
evan-bradley and
a team
as code owners
|
Ah, sorry I didn't get how to run just the |
|
@TylerHelmuth , successfully passed the unit tests now with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix: support indexing more types
Important
I'm not sure if this should support indexing into slices of
byteor[]byte(I've gone with[]bytefor nowLink to tracking issue
Fixes #29441
Testing
currently running
make gotest(it's taking longer than I expected). I noticed that #35581 added toe2e_test.go. I can add a test case there, but it'll take me a bit longer to grok how those are workingUpdate: I'm currently getting
make gotestfailures onmainfrominternal/scraper/processscraperDocumentation
changelog