[receiver/solace]: Update broker config #36387
Open
+43
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Could you find a way to avoid a breaking change here? Maybe set the broker field to any and introspect if it's a slice, in which case you'd raise a warning to move it to string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The broker field is a list of strings but only the first element is considered. This is misleading because users might think that the component supports connecting to several brokers.
If the idea is to support connecting to several brokers in the future, I think that the structure of the config would need to change anyway because we should allow the possibility to configure a queue and credentials for each broker independently.
This is a breaking change.
Testing
The tests were updated.
Documentation
The examples in the doc were updated.