[exporter/clickhouse] Fix incorrect ServiceName set for Logs Records #36350
+68
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
hanjm
approved these changes
Nov 15, 2024
|
any plans when this will be merge, We are facing the same issue |
ChrsMark
approved these changes
Nov 15, 2024
| component: clickhouseexporter | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Fix incorrect ServiceName set for Logs Records |
There was a problem hiding this comment.
nit: maybe mention service.name since that's user facing message
Suggested change
| note: Fix incorrect ServiceName set for Logs Records | |
| note: Fix incorrect service.name set for Logs Records |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing a bug in
clickhouseexporterwhen ServiceName field in ClickHouse forotel_logstable is set from previous Log Record, when current LogRecord doesn't haveservice.namesetLink to tracking issue
Fixes #36349
Testing
Respective unit test is added to code