Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/pdatatest] support Profiles signal comparison #36273

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 8, 2024

Description

Link to tracking issue

Fixes #36232

@djaglowski
Copy link
Member

It would be great to have someone familiar with profiles review this too.

@odubajDT
Copy link
Contributor Author

It would be great to have someone familiar with profiles review this too.

I am still adding CompareOptions + unit tests to be sure everything is working as expected. But a pre-review would be very appreciated!

@odubajDT odubajDT force-pushed the profiles-pdata branch 2 times, most recently from e1bd91c to fc20bd7 Compare November 13, 2024 10:27
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT marked this pull request as ready for review November 14, 2024 07:52
@odubajDT odubajDT requested a review from a team as a code owner November 14, 2024 07:52
Signed-off-by: odubajDT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pkg/pdatatest] Support profiles signal comparison
3 participants