Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/opampsupervisor] feat: Support environment variable expansion in supervisor config #36270

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[cmd/opampsupervisor] feat: Support environment variable expansion in supervisor config #36270

wants to merge 6 commits into from
+312 −17

Conversation

mrsillydog
Copy link
Contributor

@mrsillydog mrsillydog commented Nov 7, 2024 •
edited
Loading

Description

This PR allows for the usage of environment variables within the OpAMP supervisor config.

Link to tracking issue

#36269

Testing

  • Unit testing for the configuration loading process
  • Manual testing of OpAMP supervisor configuration using the experimentation process described here

@mrsillydog mrsillydog marked this pull request as ready for review November 8, 2024 18:05
@mrsillydog mrsillydog requested a review from a team as a code owner November 8, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dmitryax dmitryax

Labels
cmd/opampsupervisor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrsillydog @dmitryax