Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/prometheus] Fix static scrape config with Target Allocator #36063

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[receiver/prometheus] Fix static scrape config with Target Allocator #36063

wants to merge 2 commits into from
+126 −2

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Oct 29, 2024 •
edited
Loading

Description

Instead of clearing out prometheus scrape configuration I changed the code to copy the initial config every time we sync it from Target Allocator

Link to tracking issue

Fixes #36062 and open-telemetry/opentelemetry-operator#3034

Testing

tested in kind cluster with custom image

Documentation

@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label Oct 29, 2024
@povilasv povilasv mentioned this pull request Oct 29, 2024
Open
@povilasv povilasv marked this pull request as ready for review October 29, 2024 12:35
@povilasv povilasv requested a review from a team as a code owner October 29, 2024 12:35
@atoulme
Copy link
Contributor

atoulme commented Nov 9, 2024

Interesting. Can you please add a test?

@povilasv
Copy link
Contributor Author

@atoulme added a test 👍

@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@dmitryax dmitryax

Labels
ready to merge Code review completed; ready to merge by maintainers receiver/prometheus Prometheus receiver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[receiver/prometheus] static scape config doesn't work with Target Allocator
4 participants
@povilasv @atoulme @dashpole @dmitryax