[receiver/zipkin] move global server configuration parameters to a separate parameter #35851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
andrzej-stencel,
crobert-1 and
MovieStoreGuy
odubajDT
changed the title
odubajDT
force-pushed
the
refactor-zipkinreceiver
branch
from
19be99b
to
d7fe5ae
Compare
|
@andrzej-stencel would you please have time for a review? |
odubajDT
force-pushed
the
refactor-zipkinreceiver
branch
from
0fc263b
to
ca05388
Compare
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking |
There was a problem hiding this comment.
Can you explain why marking this as a breaking change?
There was a problem hiding this comment.
it's changing the configuration of the receiver even if it's changed behind a feature gate, but the user will be affected if the feature gate will be turned on/off. Do you consider this more as a deprecation?
…parate parameter Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Andrzej Stencel <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
refactor-zipkinreceiver
branch
from
4a31165
to
8a59a9a
Compare
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move global server configuration parameters to a separate parameter under
protocolsparameter to allow future support of different protocols (like UDP), more context hereLink to tracking issue
Fixes #35730
Testing
Documentation