[receiver/datadogreceiver] Return json for traces if the version is > 0.3 #35705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
boostchicken,
gouthamve,
jpkrohling and
MovieStoreGuy
Is there anything you need help with please reach here or within the CNCF slack :) |
|
Thanks @MovieStoreGuy. It looks like I'll need a little assistance in getting the workflow to run. Also any other assistance to get this merged . |
jmeagher
changed the title
jmeagher
changed the title
jmeagher
force-pushed
the
jmeagher-return-json-for-some-traces
branch
from
b276543
to
c08a3c1
Compare
|
This is ready for a re-run of the tests. It got a failure on the last run from something Elasticsearch related. I rebased and hope it will pass this time. I didn't see any errors related to this code change. |
jmeagher
force-pushed
the
jmeagher-return-json-for-some-traces
branch
from
c08a3c1
to
6d76385
Compare
MovieStoreGuy
approved these changes
Oct 14, 2024
|
I'm not authorized to merge this. If you're happy with it so am I. Merge at will. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@MovieStoreGuy @jpkrohling what are the next steps for this? I think it's all ready for a merge or any additional reviews that are needed. |
MovieStoreGuy
approved these changes
Oct 30, 2024
ArthurSens
pushed a commit
to ArthurSens/opentelemetry-collector-contrib
that referenced
this pull request
Nov 4, 2024
… 0.3 (open-telemetry#35705) #### Description Problem: * [The Datadog agent for versions > 0.3 returns Json instead of "Ok"](https://github.com/DataDog/datadog-agent/blob/86b2ae24f93941447a5bf0a2b6419caed77e76dd/pkg/trace/api/api.go#L511-L519) * [dd-trace-js is using V0.4 for sending data to Datadog and that expects to get a JSON response back](https://github.com/DataDog/dd-trace-js/blob/2d175d30d5ad7291c238819116a07f003074316b/packages/dd-trace/src/exporters/agent/writer.js#L52) * When sending traces from NodeJS with the dd-trace-js library it works, but throws a high volume of errors from the non-json response. Fix: For trace submissions with a version > 0.3 return a valid, but empty Json response. <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit test to ensure the expected responses to traces are returned. --------- Co-authored-by: Sean Marciniak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem:
Fix: For trace submissions with a version > 0.3 return a valid, but empty Json response.
Testing
Added unit test to ensure the expected responses to traces are returned.