feat: added translation rw2 translation for gauges

[jmichalek132]

Description

Draft starting the work on adding support for remote write 2.0 in the translation package.
Adding support for translating gauges.

This is first iteration and to keep the PR small

• we don't handle duplicate metrics
• only support gauges
• don't handle other labels than metric name
• don't handle exemplars
• don't handle metadata

Link to tracking issue #33661

Fixes

Testing

Documentation

[jmichalek132]

Do we add changelog entry for this PR too?
Do we want this partial PRs to show up in changelog?

[dashpole]

Yes, please add a changelog for this PR, and future PRs if there are any notable changes.

[jmichalek132]

Not sure why the unit tests (link) keep failing when the expected and the output matches https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11243820134/job/31260663519?pr=35703#step:8:321.

[dashpole]

Yeah strange. Almost seems like it is something to do with the NaNs.

[jmichalek132]

@dashpole could you please add @ArthurSens and @aknuds1 as reviewers too?

[dashpole]

I can't add @aknuds1, but i've added arthur

[aknuds1]

I'm having a look.

[dashpole]

prometheusremotewrite/metrics_to_prw_v2_test.go:11: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)
	writev2 "github.com/prometheus/prometheus/prompb/io/prometheus/write/v2"
prometheusremotewrite/metrics_to_prw_v2_test.go:15: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)

	"github.com/stretchr/testify/require"
prometheusremotewrite/number_data_points_v2_test.go:10: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)

looks like imports are not grouped corrrectly

[jmichalek132]

prometheusremotewrite/metrics_to_prw_v2_test.go:11: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)
	writev2 "github.com/prometheus/prometheus/prompb/io/prometheus/write/v2"
prometheusremotewrite/metrics_to_prw_v2_test.go:15: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)

	"github.com/stretchr/testify/require"
prometheusremotewrite/number_data_points_v2_test.go:10: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)

looks like imports are not grouped corrrectly

should be fixed.

[ArthurSens]

Since prometheusconverter is a private object, users of this package need a way of retrieving the symbols table somehow.

Maybe FromMetricsV2 should also return that? (It can return nil for now)

[dashpole]

Is the symbol table meant to be per-request, or long-lived? But regardless it probably makes sense to return both, since both are needed in the request.

[ArthurSens]

It's per request. PRW is meant to be stateless

[dashpole]

then returning it makes sense to me.

[jmichalek132]

Will update the PR, should we also make sure it's empty before each request?

[ArthurSens]

FromMetricsV2() starts with newPrometheusConverterV2(), so I'm assuming it's impossible to not be empty, right?

[jmichalek132]

oh yeah your are right

[jmichalek132]

Addressed in new PR #35734

[jmichalek132]

sorry my bad closing this PR and opening a new one

[bertysentry]

[like] Bertrand Martin reacted to your message:

________________________________ From: Juraj Michálek ***@***.***> Sent: Thursday, October 10, 2024 7:34:04 PM To: open-telemetry/opentelemetry-collector-contrib ***@***.***> Cc: Bertrand Martin ***@***.***>; Review requested ***@***.***> Subject: Re: [open-telemetry/opentelemetry-collector-contrib] feat: added translation rw2 translation for gauges (PR #35703) @jmichalek132 commented on this pull request.

________________________________ In pkg/translator/prometheusremotewrite/metrics_to_prw_v2.go<#35703 (comment)>:

+// FromMetricsV2 converts pmetric.Metrics to Prometheus remote write format 2.0.

+func FromMetricsV2(md pmetric.Metrics, settings Settings) (map[string]*writev2.TimeSeries, error) { + c := newPrometheusConverterV2() + errs := c.fromMetrics(md, settings) + tss := c.timeSeries() + out := make(map[string]*writev2.TimeSeries, len(tss)) + for i := range tss { + out[strconv.Itoa(i)] = &tss[i] + } + + return out, errs +} + +// prometheusConverterV2 converts from OTLP to Prometheus write 2.0 format. +type prometheusConverterV2 struct { + // TODO handle conflicts + unique map[uint64]*writev2.TimeSeries + symbolTable writev2.SymbolsTable +} + +func newPrometheusConverterV2() *prometheusConverterV2 { + return &prometheusConverterV2{ + unique: map[uint64]*writev2.TimeSeries{}, + symbolTable: writev2.NewSymbolTable(), + } +} Addressed in new PR #35734<#35734> — Reply to this email directly, view it on GitHub<#35703 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHYD3YWKY4OLYHUJQXVXAKDZ23JCZAVCNFSM6AAAAABPS64XRKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRRGI2DCNZYG4>. You are receiving this because your review was requested.Message ID: ***@***.***>