Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/splunkenterprise] 35445 add kvstore telemetry #35657

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

shalper2
Copy link
Contributor

@shalper2 shalper2 commented Oct 7, 2024

Description

Add telemetry around KV Store status to the Splunk Enterprise Receiver.

Link to tracking issue

Fixes 35445

Testing

Unit tests were updated and receiver component was deployed to test environments.

Documentation

Documentation was updated to reflect additional metrics

@shalper2 shalper2 changed the title 35445 add kvstore telemetry [receiver/splunkenterprise] 35445 add kvstore telemetry Oct 8, 2024
@shalper2 shalper2 marked this pull request as ready for review October 8, 2024 14:11
@shalper2 shalper2 requested a review from a team as a code owner October 8, 2024 14:11
Copy link
Contributor

@greatestusername greatestusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Open question: Any other attributes that might be useful? instance id/guid or some other identifier?

@MovieStoreGuy
Copy link
Contributor

This looks good to me!

Open question: Any other attributes that might be useful? instance id/guid or some other identifier?

You could apply those as part of the resource or attribute processor, if you have any recommend values I would suggest adding it as an example configuration in the README :)

@MovieStoreGuy
Copy link
Contributor

Are you able to add any tests to help validate that this works as expected?

@shalper2 shalper2 force-pushed the 35445-add-kvstore-telemetry branch 2 times, most recently from 4c50fad to edf070f Compare October 9, 2024 20:02
@shalper2 shalper2 force-pushed the 35445-add-kvstore-telemetry branch 2 times, most recently from 5bddfc7 to 3d61fad Compare October 22, 2024 12:57
@shalper2
Copy link
Contributor Author

Any chance we can mark this as ready to merge?

@mx-psi
Copy link
Member

mx-psi commented Oct 22, 2024

Any chance we can mark this as ready to merge?

There is a required test that is failing, we cannot merge until that is fixed

@shalper2
Copy link
Contributor Author

Aaah sorry forgot to make generare after rebasing.

@shalper2
Copy link
Contributor Author

@mx-psi should be all good to go now!

@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Oct 23, 2024
@mx-psi mx-psi merged commit 50e7236 into open-telemetry:main Oct 23, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/splunkenterprise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/splunkenterprise] Adding Telemetry around KV Store
4 participants