Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostmetricsreceiver: migrate to newer semconv version #35604

Closed

Conversation

narcis96
Copy link
Contributor

@narcis96 narcis96 commented Oct 4, 2024

Description: The version of semconv is upgraded to v1.27.0

This is a trivial upgrade. The semconv attributes' value have been compared using go-otel-semconv-comparator. All attributes used by this component have the same value in both versions.

Link to tracking Issue: #22095

Testing: Tests passed


"github.com/open-telemetry/opentelemetry-collector-contrib/internal/filter/filterset"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This newline might break goimports lint check.

@braydonk
Copy link
Contributor

braydonk commented Oct 4, 2024

This PR can skip changelog, if someone with access could add the Skip Changelog label that would be helpful.

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 4, 2024
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change feels a bit weird. We update the version of SemConv and I'd expect that we would face breaking changes because of the WiP happening in System SemConv but we don't because the SemConvs are not actually used in this receiver?

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 23, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/hostmetrics Skip Changelog PRs that do not require a CHANGELOG.md entry Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants