-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hostmetricsreceiver: migrate to newer semconv version #35604
Conversation
|
||
"github.com/open-telemetry/opentelemetry-collector-contrib/internal/filter/filterset" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This newline might break goimports
lint check.
This PR can skip changelog, if someone with access could add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change feels a bit weird. We update the version of SemConv and I'd expect that we would face breaking changes because of the WiP happening in System SemConv but we don't because the SemConvs are not actually used in this receiver?
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description: The version of semconv is upgraded to v1.27.0
This is a trivial upgrade. The semconv attributes' value have been compared using go-otel-semconv-comparator. All attributes used by this component have the same value in both versions.
Link to tracking Issue: #22095
Testing: Tests passed