Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awsxrayreceiver: migrate to newer semconv version #35600

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

narcis96
Copy link
Contributor

@narcis96 narcis96 commented Oct 4, 2024

Description: The version of semconv is upgraded from v1.6.1 to v1.18.0

This is a trivial upgrade. The semconv attributes' value have been compared using go-otel-semconv-comparator. All attributes used by this component have the same value in both versions.

Link to tracking Issue: #22095

Testing: Tests passed

@narcis96 narcis96 requested a review from a team as a code owner October 4, 2024 08:25
@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 4, 2024
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why v1.18.0 instead of v1.27.0 in other PRs?

@narcis96
Copy link
Contributor Author

why v1.18.0 instead of v1.27.0 in other PRs?

v1.18.0 is the most newer version that still keep the code from compiling

@narcis96
Copy link
Contributor Author

PTAL

@MovieStoreGuy
@srprash
@wangzlei

@narcis96
Copy link
Contributor Author

Kind reminder here: @MovieStoreGuy @srprash @wangzlei @mx-psi

Copy link
Contributor

github-actions bot commented Nov 8, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 8, 2024
@MovieStoreGuy MovieStoreGuy merged commit 4b322db into open-telemetry:main Nov 10, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 10, 2024
pull bot pushed a commit to abaguas/opentelemetry-collector-contrib that referenced this pull request Nov 11, 2024
Description: The version of semconv is upgraded from v1.6.1 to v1.18.0

This is a trivial upgrade. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator).
All attributes used by this component have the same value in both
versions.

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/awsxray Skip Changelog PRs that do not require a CHANGELOG.md entry Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants