[extension/opamp] Add os.description as non-identifying agent attribute
#35561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
BinaryFissionGames,
evan-bradley,
portertech and
tigrannajaryan
dpaasman00
force-pushed
the
opampextension-add-os-desc-semconv
branch
3 times, most recently
from
f6e3879
to
76ba1fa
Compare
dpaasman00
commented
Oct 4, 2024
cmd/opampsupervisor/e2e_test.go
Outdated
| @@ -1457,3 +1458,38 @@ func findRandomPort() (int, error) { | |||
|
|
|||
| return port, nil | |||
| } | |||
|
|
|||
| func getOSDescription(t *testing.T) string { | |||
There was a problem hiding this comment.
Not sure if there's a better way to get this test passing other than just copying this code from the opamp extension test?
dpaasman00
force-pushed
the
opampextension-add-os-desc-semconv
branch
3 times, most recently
from
e548ca2
to
04991a9
Compare
dpaasman00
force-pushed
the
opampextension-add-os-desc-semconv
branch
from
8bf8823
to
0a5cae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The opamp extension now reports additional information about the host machine's operating system, specifically the version. It does so by reporting the semantic convention
os.description(defined here) as a non-identifying attribute in the agent description message.Link to tracking Issue: Closes #35555
Testing: Unit tests updated.
Verified
os.descriptionattribute shows up with values like 'macOS 15.0' and 'Ubuntu 20.04.6 LTS'Documentation: