fix: update regex parsing for container logs to support windows file #35559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
squ1d123
force-pushed
the
error-filelog-windows-operator
branch
2 times, most recently
from
ed61065
to
0df15fe
Compare
ChrsMark
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
This change makes sense to me. Thank's! @squ1d123 could you add a changelog entry for this (make chlog-new and fill appropriately)?
@djaglowski @pjanotti please take a look.
squ1d123
force-pushed
the
error-filelog-windows-operator
branch
2 times, most recently
from
456b2f3
to
1509667
Compare
djaglowski
approved these changes
Oct 3, 2024
squ1d123
force-pushed
the
error-filelog-windows-operator
branch
4 times, most recently
from
7572554
to
1f27f98
Compare
pjanotti
approved these changes
Oct 4, 2024
squ1d123
force-pushed
the
error-filelog-windows-operator
branch
from
1f27f98
to
fd9149d
Compare
squ1d123
force-pushed
the
error-filelog-windows-operator
branch
from
fd9149d
to
bd0a9d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seperator
Description:
This PR updates add support to parse container filepaths on windows hosts
Link to tracking Issue:
#35558
Testing:
Additional unit test to test regex parsing for windows filepaths
Documentation:
N/A