-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/elasticsearch] Add sanitization utils for datastream fields #35494
[exporter/elasticsearch] Add sanitization utils for datastream fields #35494
Conversation
…/opentelemetry-collector-contrib into elastic-sanitize-datastream-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good functionality wise. A couple of minor comments.
…/opentelemetry-collector-contrib into elastic-sanitize-datastream-fields
@carsonip I have improved the |
@carsonip I also added a test to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch about the otel suffix! a comment about refactoring
…/opentelemetry-collector-contrib into elastic-sanitize-datastream-fields
…/opentelemetry-collector-contrib into elastic-sanitize-datastream-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be documented?
Hi @andrzej-stencel, I've updated the readme of ES exported to reference the restriction docs. Let me know if this suffices, or if you think I should articulate things differently. |
Thanks @rubvs, this is better than nothing. Ideally the docs would mention that the restricted characters will be replaced with underscores |
Please resolve conflicts. |
Description: Adds util functions to sanitize data stream fields
Link to tracking Issue: Fixes #34285
Testing: Added unit tests