[receiver/nginx] Use NewDefaultClientConfig instead of manually creating struct #35452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing struct Signed-off-by: ChrsMark <[email protected]>
atoulme
approved these changes
Sep 27, 2024
29 tasks
mackjmr
reviewed
Oct 1, 2024
receiver/nginxreceiver/factory.go
Outdated
| clientConfig.MaxIdleConns = nil | ||
| clientConfig.MaxIdleConnsPerHost = nil | ||
| clientConfig.MaxConnsPerHost = nil | ||
| clientConfig.IdleConnTimeout = nil |
There was a problem hiding this comment.
clientConfig.MaxIdleConns = nil
clientConfig.MaxIdleConnsPerHost = nil
clientConfig.MaxConnsPerHost = nil
clientConfig.IdleConnTimeout = nil
This part can be deleted, for MaxIdleConns, MaxIdleConnsPerHost, MaxConnsPerHost, IdleConnTimeout even if you set to nil here, the same defaults end up being used in the call to ToClient: https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/confighttp/confighttp.go#L136.
Note you may need to update some tests similarly to: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/35518/files#diff-f1add4d95d0ec4f45889d7b60c61a9a274ab2f22f5013b9063a6b1baddd660e3R82
There was a problem hiding this comment.
Thank's! I have updated the patch.
Signed-off-by: ChrsMark <[email protected]>
mackjmr
approved these changes
Oct 1, 2024
djaglowski
pushed a commit
that referenced
this pull request
Oct 9, 2024
…f manual initialization (#35509) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Similar to #35452 but for the `elasticsearch` receiver. **Link to tracking Issue:** <Issue number if applicable> #35457 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
djaglowski
approved these changes
Oct 9, 2024
jmichalek132
pushed a commit
to jmichalek132/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2024
…f manual initialization (open-telemetry#35509) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Similar to open-telemetry#35452 but for the `elasticsearch` receiver. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#35457 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
jmichalek132
pushed a commit
to jmichalek132/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2024
…ing struct (open-telemetry#35452) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Similar to open-telemetry/opentelemetry-collector#11273. This PR makes usage of the `NewDefaultClientConfig` instead of manually creating the `confighttp.ClientConfig` struct as part of open-telemetry#35457. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#35457 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Signed-off-by: ChrsMark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Similar to open-telemetry/opentelemetry-collector#11273.
This PR makes usage of the
NewDefaultClientConfiginstead of manually creating theconfighttp.ClientConfigstruct as part of #35457.Link to tracking Issue: #35457
Testing:
Documentation: