[receiver/tlscheck] Inital Commit of TLS Check Receiver #35441
Conversation
michael-burt
changed the title
michael-burt
force-pushed
the
tlscheckreceiver
branch
4 times, most recently
from
77ab636
to
b1818e0
Compare
michael-burt
force-pushed
the
tlscheckreceiver
branch
2 times, most recently
from
4732a4a
to
2ebf9ee
Compare
github-actions
bot
added
cmd/otelcontribcol
michael-burt
force-pushed
the
tlscheckreceiver
branch
5 times, most recently
from
9ef2ddd
to
b2e523a
Compare
michael-burt
force-pushed
the
tlscheckreceiver
branch
from
c43a81f
to
48103c1
Compare
michael-burt
requested review from
djaglowski,
dmitryax,
jpkrohling,
TylerHelmuth,
bogdandrutu,
evan-bradley and
tigrannajaryan
as code owners
github-actions
bot
requested review from
frzifus,
gouthamve,
hughesjj,
jamesmoessis,
JaredTan95,
jpkrohling,
lahsivjar,
michalpristas,
mxiamxia,
pavolloffay,
pdelewski,
psx95,
punya,
pxaws,
rapphil,
rmfitzpatrick,
rogercoll,
StefanKurek,
tamir-michaeli,
VihasMakwana and
yotamloe
| if cfg.URL == "" { | ||
| err = multierr.Append(err, errMissingURL) | ||
| } else { | ||
| _, parseErr := url.ParseRequestURI(cfg.URL) |
There was a problem hiding this comment.
What is the expected behavior (of validate && the receiver) for a non-https URL? I would expect it to be invalid at validate time, as I don't see a good mechanism for returning that information at runtime in a way that would be consumable.
There was a problem hiding this comment.
That is a good point and something definitely overlooked.
For the sake of the PR being open so long and becoming harder to merge, I would love to see this as a follow up PR instead updating the current PR.
There was a problem hiding this comment.
I don't think we should allow for scheme. We do not need to send an http request here, only establish tcp connection, so scheme doesn't make sense. Related, I think we should change url to host since we are connecting to a host address via tcp, not sending a http request to a url.
Description: Initial commit of TLS Check Receiver, a new component aimed at emitting metrics about the expoiry of x.509 certs.
Link to tracking Issue: 35423
Testing: Test files added
Documentation:
README.md&metadata.yamladded