kubeletstatsreceiver: migrate to latest semconv version #35273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
approved these changes
Sep 18, 2024
ChrsMark
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Sharing the same concern with #35238.
Such an upgrade of SemConv's version might be risky.
In addition we might need to think if we should target this upgrade now or postpone for when the K8s semantic conventions are stable (there is some work planned for this, starting soon).
In any case if we are to apply this upgrade now it would be nice to verify which SemConv attributes this receiver uses and ensure that they are not changed from one version to the other.
TylerHelmuth
requested changes
Sep 18, 2024
codeboten
reviewed
Sep 18, 2024
|
Thank's @codeboten! I can confirm it's only used at @TylerHelmuth wdyt? |
TylerHelmuth
approved these changes
Sep 19, 2024
ChrsMark
approved these changes
Sep 19, 2024
dmitryax
pushed a commit
to dmitryax/opentelemetry-collector-contrib
that referenced
this pull request
Sep 19, 2024
…ry#35273) Description: The version of semconv is upgraded from v1.6.1 to v1.27.0 Link to tracking Issue: open-telemetry#22095 Testing: Tests passed
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…ry#35273) Description: The version of semconv is upgraded from v1.6.1 to v1.27.0 Link to tracking Issue: open-telemetry#22095 Testing: Tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The version of semconv is upgraded from v1.6.1 to v1.27.0
Link to tracking Issue: #22095
Testing: Tests passed