goldendataset: fix histogram metric BucketCounts length

open-telemetry · Oct 4, 2024 · ad9a28d · ad9a28d
1 parent fb37793
commit ad9a28d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/coreinternal/goldendataset/metrics_gen.go b/internal/coreinternal/goldendataset/metrics_gen.go
@@ -176,7 +176,7 @@ func populateDoubleHistogram(cfg MetricsCfg, dh pmetric.Histogram) {
 }
 
 func setDoubleHistogramBounds(hdp pmetric.HistogramDataPoint, bounds ...float64) {
-	counts := make([]uint64, len(bounds))
+	counts := make([]uint64, len(bounds)+1)
 	hdp.BucketCounts().FromRaw(counts)
 	hdp.ExplicitBounds().FromRaw(bounds)
 }

diff --git a/internal/coreinternal/goldendataset/metrics_gen_test.go b/internal/coreinternal/goldendataset/metrics_gen_test.go
@@ -49,7 +49,7 @@ func TestDoubleHistogramFunctions(t *testing.T) {
 	pt := pmetric.NewHistogramDataPoint()
 	setDoubleHistogramBounds(pt, 1, 2, 3, 4, 5)
 	require.Equal(t, 5, pt.ExplicitBounds().Len())
-	require.Equal(t, 5, pt.BucketCounts().Len())
+	require.Equal(t, 6, pt.BucketCounts().Len())
 
 	addDoubleHistogramVal(pt, 1)
 	require.EqualValues(t, 1, pt.Count())
@@ -75,7 +75,7 @@ func TestGenDoubleHistogram(t *testing.T) {
 	pts := getMetric(md).Histogram().DataPoints()
 	pt := pts.At(0)
 	buckets := pt.BucketCounts()
-	require.Equal(t, 5, buckets.Len())
+	require.Equal(t, 6, buckets.Len())
 	require.EqualValues(t, 2, buckets.At(2))
 }